helcel/beans
2
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases 4 Wiki Activity

Special behaviour cases #53

New Issue
Closed
opened 2024-04-08 01:11:18 +02:00 by sora · 1 comment
sora commented 2024-04-08 01:11:18 +02:00
Owner
Copy Link
  1. Groups=OFF & >1 existing group: still offers the multi-group prompt. Should we delete other groups ? Should we merge groups ? Should we keep multi-group and let user do the removal manually ?
  2. EditPlace Counters: parent should take into account child with X/10 checked items with X<10 ?
  3. EditPlace Check: parent should be checked if child is 10/10, but what if multiple groups where used, what group should parent take ? Should it take most common ? Should it just show a fake checkmark ? In Groups=OFF should it behave differently than when ON ?

  • 1. Fixed

  • 2. Fixed

  • 3. Fixed

1. Groups=OFF & >1 existing group: still offers the multi-group prompt. Should we delete other groups ? Should we merge groups ? Should we keep multi-group and let user do the removal manually ? 2. EditPlace Counters: parent should take into account child with X/10 checked items with X<10 ? 3. EditPlace Check: parent should be checked if child is 10/10, but what if multiple groups where used, what group should parent take ? Should it take most common ? Should it just show a fake checkmark ? In Groups=OFF should it behave differently than when ON ? - [x] 1. Fixed - [x] 2. Fixed - [x] 3. Fixed
sora self-assigned this 2024-04-08 01:11:18 +02:00
fgerber was assigned by sora 2024-04-08 01:11:18 +02:00
fgerber commented 2024-04-08 10:56:43 +02:00
Member
Copy Link

My take on these:

  1. Should ask user which group to keep and reassign all visits to that group, then delete all other groups.
  2. Yes, if you have visited a region, you have still been in the country.
  3. Parent takes automatic group with ec52574ae3, regardless of children groups. Probably equivalent to "fake checkmark". Also works with Groups==OFF, since the AUTO_GROUP is never set and its key is prohibited by code.
My take on these: 1. Should ask user which group to keep and reassign all visits to that group, then delete all other groups. 2. Yes, if you have visited a region, you have still been in the country. 3. Parent takes automatic group with ec52574ae34e5f2ffac5db8efd5fb6e26b0a962b, regardless of children groups. Probably equivalent to "fake checkmark". Also works with Groups==OFF, since the AUTO_GROUP is never set and its key is prohibited by code.
sora closed this issue 2024-04-09 20:43:31 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees sora fgerber
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: helcel/beans#53
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?